Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert ts ~v5.4 & test typings #366

Closed
wants to merge 1 commit into from
Closed

Conversation

aladdin-add
Copy link

@aladdin-add aladdin-add commented Oct 21, 2024

  1. unignore types/index.d.ts
  2. remove npm script prepack - it's no longer auto-generated
  3. add a test for the typings

1. unignore types/index.d.ts
2. remove npm script `prepack` - it's no longer auto-generated
3. add a test for the typings
@aladdin-add aladdin-add requested a review from scagood October 21, 2024 10:34
@scagood scagood requested a review from voxpelli October 21, 2024 10:43
@scagood
Copy link

scagood commented Oct 21, 2024

I would love to workout why this is not generating correctly 🤔

Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @scagood – some explanation / justification / reference would be good – as is I can't see how this improves things

@aladdin-add
Copy link
Author

yes, I'm closing it since we have #367. thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants