Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resolve): allow overriding enhanced-resolve's options #384

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

GertSallaerts
Copy link

@GertSallaerts GertSallaerts commented Nov 14, 2024

Allows you to customize the config for module resolution. See: https://github.com/webpack/enhanced-resolve?tab=readme-ov-file#resolver-options


Old description (the PR was initially intended to only specify the modules option)

Allows you to do things like:

  • Use bower components
  • Specify your app's src folder as a modules folder and require('models/foo'); from within your src folder

Basically this: https://webpack.js.org/configuration/resolve/#resolvemodules

That second bullet point used to be possible by just setting resolvePaths but going from this comment on #139 that was considered an unintended side-effect or bug.

@GertSallaerts GertSallaerts changed the title feat(resolve): allow specifying enhanced-resolver's modules option feat(resolve): allow specifying enhanced-resolve's modules option Nov 14, 2024
@scagood scagood self-assigned this Nov 14, 2024
@scagood
Copy link

scagood commented Nov 14, 2024

Thank you for you PR!

I will review it first thing tomorrow morning.

scagood

This comment was marked as resolved.

Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@scagood scagood requested a review from aladdin-add November 15, 2024 11:35
@GertSallaerts GertSallaerts changed the title feat(resolve): allow specifying enhanced-resolve's modules option feat(resolve): allow overriding enhanced-resolve's options Nov 15, 2024
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add requested a review from scagood December 6, 2024 09:14
@aladdin-add aladdin-add merged commit 1466bec into eslint-community:master Dec 10, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants