-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate all message to messageId #482
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 24 -1
Lines 649 660 +11
Branches 250 246 -4
=========================================
+ Hits 649 660 +11 ☔ View full report in Codecov by Sentry. |
Was this one supposed to be as a draft too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like most of the names here (better than the ones I was attempting in my own PR), but just those few mentioned could I think be improved, with the naming being important since they are meant to be accessed even outside the file containing them as in the test files (so the test files can avoid specifying an exact syntax which might be contradicted by a change of the message in the rule file).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It looks per https://github.com/eslint-community/governance/pull/1/files that collaborators (and not only team members) can do merges (presumably on other-than-their-own PRs), so I'll go ahead and merge. |
I changed from |
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Migrate all
message
tomessageId
(for the update to eslint-plugin-eslint-plugin)(#471)