Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Update node versions to align with eslint v9 #484

Merged
merged 1 commit into from
Jul 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,27 +41,23 @@ jobs:
strategy:
matrix:
eslint: [8]
node: [12.22.0, 12, 14.17.0, 14, 16.0.0, 16, 18, 20]
node: [18.18.0, 20.9.0, 21.1.0, 22]
os: [ubuntu-latest]
include:
# ESLint v9
- eslint: 9
node: 20
node: 22
os: ubuntu-latest
# On other platforms
- os: windows-latest
eslint: 8
node: 18
node: 22
- os: macos-latest
eslint: 8
node: 18
# On old ESLint versions
- eslint: 7
node: 18
os: ubuntu-latest
node: 22
# On the minimum supported ESLint/Node.js version
- eslint: 7.0.0
node: 12.22.0
node: 18.18.0
os: ubuntu-latest
runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"eslint": "^7.0.0 || ^8.0.0 || ^9.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we align here as well? Supporting all the way back to ESLint 7 but only Node 18 and newer feels a bit odd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is what I did in the original PR (#471)

4db7f5d

But I think that making that a separate PR for the change log was a good idea 😀

},
"engines": {
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
"node": "^18.18.0 || ^20.9.0 || >=21.1.0"
},
"funding": "https://opencollective.com/eslint"
}