Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add format workflow #104

Closed
wants to merge 2 commits into from
Closed

Conversation

MichaelDeBoey
Copy link
Member

No description provided.

@MichaelDeBoey MichaelDeBoey requested a review from a team April 26, 2023 21:13
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.96%. Comparing base (892b2c1) to head (70910cf).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   96.96%   96.96%           
=======================================
  Files          13       13           
  Lines        2111     2111           
  Branches      396      396           
=======================================
  Hits         2047     2047           
  Misses         63       63           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the Stale label Jun 25, 2023
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that aren't actionable. Please reach out if you have more information for us! 🙂

@github-actions github-actions bot closed this Jul 2, 2023
@MichaelDeBoey MichaelDeBoey reopened this Jul 3, 2023
@github-actions github-actions bot removed the Stale label Jul 3, 2023
@github-actions github-actions bot added the Stale label Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that aren't actionable. Please reach out if you have more information for us! 🙂

@github-actions github-actions bot closed this Sep 8, 2023
@MichaelDeBoey MichaelDeBoey reopened this Oct 14, 2023
@github-actions github-actions bot added Stale and removed Stale labels Dec 13, 2023
Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since CI fails when the code isn't formatted correctly we shouldn't ever end up with wrongly formatted code in main?

And if we do, I would prefer an automated PR to be raised instead, like I did here: https://github.com/SocketDev/workflows/blob/fe40aa6135a5ea6d81ad8103e4f044d2f9227e41/.github/workflows/reusable-sync.yml#L182-L208

@MichaelDeBoey MichaelDeBoey deleted the MichaelDeBoey-patch-2 branch October 25, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants