chore: use @babel/register instead of esm
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## eslint-8 #16 +/- ##
===========================================
Coverage ? 96.01%
===========================================
Files ? 13
Lines ? 653
Branches ? 0
===========================================
Hits ? 627
Misses ? 26
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hmm. It doesn't seem to work. It seems to hang on Node v12. |
ota-meshi
changed the title
@babel/register instead of esm.
ota-meshi
changed the title
@babel/register instead of esm.@babel/register instead of esm
|
I changed to use |
MichaelDeBoey
approved these changes
Nov 27, 2022
MichaelDeBoey
pushed a commit
that referenced
this pull request
Nov 27, 2022
* chore: use esbuild-register instead of esm. * chore: add esbuild to deps * chore: use @babel/register instead of esbuild-register
MichaelDeBoey
added a commit
that referenced
this pull request
Nov 27, 2022
* feat: support ESLint 8.x * chore: use `@babel/register` instead of `esm` (#16) * chore: use esbuild-register instead of esm. * chore: add esbuild to deps * chore: use @babel/register instead of esbuild-register Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a PR to the eslint-8 branch.
This PR uses
esbuild-register@babel/registerinstead of theesmpackage. Theesmpackage doesn't seem to work when mixed with real ESM modules.mochajs/mocha#4671