Add support for sonarjs #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
changed the title
Shinigami92
reviewed
Oct 1, 2022
Julien-R44
force-pushed
the
feat/eslint-plugin-sonarjs
branch
from
684f656
to
0ee8041
Compare
|
@Julien-R44 There is also another related eslint plugin https://github.com/un-ts/eslint-plugin-sonar |
|
Thanks for sharing, I didn't know. Would also be cool to have |
Shinigami92
reviewed
Oct 25, 2022
| @@ -55,6 +55,7 @@ | |||
| "@types/node": "~18.7.23", | |||
| "@types/prettier": "~2.7.1", | |||
| "@typescript-eslint/eslint-plugin": "~5.38.1", | |||
| "@typescript-eslint/experimental-utils": "^5.38.1", | |||
There was a problem hiding this comment.
I can't remember why ahah. I'm sorry for the delay @Shinigami92 I have a lot of stuff to do right now 🥲
I think I'll get back to the project in a week or two and resume theses PR
However, what I wanted to do was to finish our patch module, and once merged, regenerate the types for the plugins I proposed PRs for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/SonarSource/eslint-plugin-sonarjs
Related to #131