Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: style issues in no-js mode #628

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: style issues in no-js mode #628

wants to merge 5 commits into from

Conversation

Tanujkanti4441
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

There are some styles that are different in no-js mode as compared enabled javascript mode.

What changes did you make? (Give an overview)

This PR fixes following style in no-js mode.

JavaScript Enabled JavaScript Disabled

Related Issues

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Sep 17, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 34736e4
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/672c6f835415940008556fb6
😎 Deploy Preview https://deploy-preview-628--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 34736e4
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/672c6f834d8e1900083592fd
😎 Deploy Preview https://deploy-preview-628--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 34736e4
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/672c6f831b10db0008477433
😎 Deploy Preview https://deploy-preview-628--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 34736e4
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/672c6f83ffe8cc0008b8cbf9
😎 Deploy Preview https://deploy-preview-628--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 34736e4
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/672c6f8326dd0d00083ff886
😎 Deploy Preview https://deploy-preview-628--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 34736e4
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/672c6f83f1637d00088a4a4e
😎 Deploy Preview https://deploy-preview-628--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 34736e4
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/672c6f838e3f0f0008f57bfe
😎 Deploy Preview https://deploy-preview-628--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 34736e4
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/672c6f8300d6c000084cdbb5
😎 Deploy Preview https://deploy-preview-628--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

amareshsm
amareshsm reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint issue; Prettier is failing.

@amareshsm
Copy link
Member

amareshsm commented Sep 22, 2024 •
edited
Loading

A few issues still need to be addressed:

  1. On the donation page, the GitHub company logo is not visible in the "Ways to Sponsor" section when using dark theme in no-JS mode.

image

  1. Need to correct the styling for the code blocks.
    image

amareshsm
amareshsm reviewed Sep 26, 2024
View reviewed changes
Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the light theme ESLint logo is not visible

image

@Tanujkanti4441
Copy link
Contributor Author

Tanujkanti4441 commented Sep 27, 2024 •
edited
Loading

In the light theme ESLint logo is not visible

I could not reproduce this, can you please share if it is in js or no-js mode, or any steps to reproduce?

@amareshsm
Copy link
Member

In the light theme ESLint logo is not visible

I could not reproduce this, can you please share if it is in js or no-js mode, or any steps to reproduce?

I can reproduce this issue locally. you can check this preview link in the no-js mode light theme the ESlint logo is not visible.

amareshsm
amareshsm reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tanujkanti4441 Hey can you this pr once I checked it looks like all of the issues are fixed.

@Tanujkanti4441
Copy link
Contributor Author

@Tanujkanti4441 Hey can you this pr once I checked it looks like all of the issues are fixed.

We still have font-weight related issues as eslint/eslint#18916 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amareshsm amareshsm amareshsm left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
accepted bug Something isn't working
Projects
Triage
Status: Implementing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tanujkanti4441 @amareshsm