Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: --quiet should not supress --max-warnings (fixes #14202) #14242

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #14202

What changes did you make? (Give an overview)

ESLint will now return exit code 1 and show the "too many warnings" error message when the number of warnings exceeds --max-warnings even if the --quiet flag was used. ESLint will still not show the actual warnings in that case.

Is there anything you'd like reviewers to focus on?

Marked as "Update" since it can produce exit code 1 for runs that used to have exit code 0.

@mdjermanovic mdjermanovic added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Mar 23, 2021
@mdjermanovic
Copy link
Member Author

@aladdin-add I got a notification from you that this didn't work when tested locally. Is that still the case?

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aladdin-add
Copy link
Member

I forgot to checkout to the branch >﹏<, it was working fine after checking out to the right branch.

sorry for the misleading! :)

@nzakas nzakas merged commit 43f1685 into master Mar 25, 2021
@nzakas nzakas deleted the issue14202 branch March 25, 2021 00:32
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Sep 22, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using --max-warnings in combination with --quiet should error
4 participants