Chore: pin fs-teardown@0.1.1 #14771
Merged
Chore: pin fs-teardown@0.1.1 #14771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 5, 2021
nzakas
approved these changes
Jul 6, 2021
snitin315
approved these changes
Jul 6, 2021
1 task
btmills
approved these changes
Jul 6, 2021
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
This pins
"fs-teardown": "0.1.1"to fix our CI on Node 10.12.0.The latest 0.1.3 doesn't work on Node 10.12.0:
https://github.com/eslint/eslint/pull/14769/checks?check_run_id=2993896202
The previous 0.1.2 had a breaking change with trimming file contents. That wasn't noticed in this repo, but breaks some tests in eslint/eslintrc (eslint/eslintrc#44) so it feels safe to avoid the change.
What changes did you make? (Give an overview)
Set
"fs-teardown": "0.1.1"in package.json.Is there anything you'd like reviewers to focus on?
We can probably revert this change once we merge #14592