Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken scripts in tools/ and convert to esm #471

Closed
mreinstein opened this issue Mar 17, 2021 · 2 comments · Fixed by #476
Closed

Fix broken scripts in tools/ and convert to esm #471

mreinstein opened this issue Mar 17, 2021 · 2 comments · Fixed by #476
Assignees

Comments

@mreinstein
Copy link
Contributor

As per discussion in #469 (comment) there are several files in the tools/ directory that are not functioning, and are also declared as commonjs modules.

@nzakas
Copy link
Member

nzakas commented Mar 18, 2021

Thanks!

@nzakas
Copy link
Member

nzakas commented Apr 16, 2021

Working on this.

nzakas added a commit that referenced this issue Apr 16, 2021
@mdjermanovic mdjermanovic linked a pull request Apr 19, 2021 that will close this issue
nzakas added a commit that referenced this issue Apr 21, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Chore: Fix/remove tools (fixes #471)

* Update tests tools
@nzakas nzakas moved this to Complete in Triage Jan 3, 2023
@nzakas nzakas added this to Triage Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants