-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Upgrade Acorn to support ES2017 (fixes #287) #290
Conversation
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
Can you add some tests for trailing commas in function arguments too? function foo(a, b,) {}
var foo = function(a, b,) {};
var foo = (a, b,) => {};
foo(a, b,); |
Certainly! |
Added |
Hold on, some issues with the tests. 1 sec. |
K tests are in. Turns out your tests should default to |
Oh and I need to fix my github author. Used my paypal account... |
Just squashed it into your orgiinal commit if that's alright. |
Wow, amazing, near 20K lines 😮 |
Lol @mysticatea it's just the generated tests. New code is like 10 lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Awesome stuff!
This PR adds support for
ecmaVersion: 8
to espree by using the latestacorn
.The main requested new feature here is support for
async
andawait
.I copied all of the test cases from the acorn test suite here (there are piles of them):
https://github.com/ternjs/acorn/blob/master/test/tests-asyncawait.js
Still needs rebasing, etc.