Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: To support year in ecmaVersion number (fixes #300) #301

Merged
merged 1 commit into from
Oct 21, 2016
Merged

Conversation

gyandeeps
Copy link
Member

@gyandeeps gyandeeps commented Oct 20, 2016

Need Feedback: Should we print different error messages for the year based vs pure numbers or we just use a common error message.

@kaicataldo
Copy link
Member

Do we want to duplicate the normalizing logic in ESLint still? https://github.com/eslint/eslint/blob/cbbe420433726a5c7f38b132efac2945053966d5/lib/eslint.js#L427

@gyandeeps
Copy link
Member Author

I will work on that once I have this PR merged.

@nzakas
Copy link
Member

nzakas commented Oct 21, 2016

We should leave the ESLint logic as-is because it affects more than just Espree.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzakas nzakas merged commit e5df542 into master Oct 21, 2016
@gyandeeps gyandeeps deleted the issue300 branch October 21, 2016 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants