Update: add latestEcmaVersion & supportedEcmaVersions #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nzakas
approved these changes
Feb 12, 2020
lib/options.js
Outdated
| * Get the latest ECMAScript version supported by Espree. | ||
| * @returns {number} The latest ECMAScript version. | ||
| */ | ||
| function latestEcmaVersion() { |
There was a problem hiding this comment.
I’d suggest calling this getLatestEcmaVersion to indicate a value is being retrieved (verb as opposed to noun).
There was a problem hiding this comment.
Good call! I was initially thinking of it being more of a static property (like version), but that makes more sense with this iteration 👍
lib/options.js
Outdated
| * Get the list of ECMAScript versions supported by Espree. | ||
| * @returns {number[]} An array containing the supported ECMAScript versions. | ||
| */ | ||
| function supportedEcmaVersions() { |
There was a problem hiding this comment.
Similarly, getSupportedEcmaVersions.
lib/options.js
Outdated
| * @returns {number} The latest ECMAScript version. | ||
| */ | ||
| function latestEcmaVersion() { | ||
| return Math.max(...SUPPORTED_VERSIONS); |
There was a problem hiding this comment.
You can avoid a calculation here by using SUPPORTED_VERSIONS[SUPPORTED_VERSIONS.length - 1]
|
Thanks for the review! Updated. |
kaicataldo
changed the title
|
Ah, I like that! That’s more in line with my initial design and I think is a nicer API. Will update. |
kaicataldo
force-pushed
the
ecmaversion-apis
branch
from
1439ee6 to
270da9c
Compare
kaicataldo
changed the title
kaicataldo
changed the title
btmills
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by this discussion, this is a proposal to add
latestEcmaVersion()&supportedEcmaVersions()to the public API.Benefits:
ecmaVersionfrom the parser for rules (as is mentioned in the comment listed above).ecmaVersions in our demo have gotten out of sync with ESLint core. This would allow us to calculate this programmatically and not have to manually update it.Cons:
Open questions: