-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: new site for docs #436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, very cool! Thanks for doing this.
Is it possible for you to add a script that will auto run docsify as part of this PR?
Wow, I hadn't heard of Docsify before. This is really cool. Re the demo, I think we should point people to AST Explorer, since it's an existing, well-maintained tool. |
@nzakas I didn't get this. Did you mean having no server to run the script like it can be run in file protocol ? |
Yes, this is better, AST Explorer does have a |
I added a demo link in the sidebar instead of navbar as it was not looking in small browser width as there is the dark mode and github banner there as well. @kaicataldo, @nzakas |
https://espree-site.netlify.com/#/ Will have a preview of the live changes 👍 |
@nzakas We won’t need a build step because it’s not actually a static site. I believe this works by pointing Netlify to @anikethsaha Is this published under your own personal account on Netlify? If so, would you be willing to transfer it to the ESLint organization so that we can maintain it going forward? This would allow us to add a custom domain as well (even if it’s just a subdomain of Regarding the AST Explorer link, I wonder if we should add this to the home page with an explanation of what AST Explorer is instead? I think having an external link without an explanation will be confusing. |
yes, everything here is the runtime
@kaicataldo
yes, it's under my personal account. I can transfer the account or if you want I will delete this site and you can simply point the publish directory in
yes it makes sense, can you share what kind of explanation I need to add cause I think it may be something about the what are ASTs, and how we can get AST in |
Ah okay, I totally misunderstood what was happening here. Thanks for explaining. I think we should be able to set up our own Netlify site to use this. Maybe we can use espree.eslint.org? |
We should probably rethink our documentation since it's so incomplete, but I think it makes sense to have a short section about AST Explorer and how it can be used to visualize the AST in the AST section of the docs. As I think about this more, I actually think we should just merge this as-is so that we can get our Netlify site set up and then iterate on it from there. |
One small comment above but otherwise this LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should merge this as-is and iterate from there. Once we get it merged I can set up the Netlify site.
Thanks for doing this! |
Agreed. Merge + iterate is the way to go. |
thanks for the quick review. |
This site is now live at https://espree.netlify.com. |
Created a site for the docs using
docsify
Site preview : https://espree-site.netlify.com/#/
Features
.md
file indocs
folder and add it to_sidebar.md
, that's it)docs about usage, about and developer guide can be added smoothly once the content is ready
about the
demo
page, as this is mostly a static site havingdemo
might be a tricky one asdocsify
is no-framework static site generator. It can be done but having no framework demo page might be heavy load. I can give it a shot if time permits 👍Screen shots
Side bar in mobile view :
I couldn't find the logo for
espree
so I usedeslint
's logo.If dark mode is not preferrable, let me know, I will remove the plugin for it
ref #25