Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: move to GitHub Actions #449

Merged
merged 5 commits into from
Aug 11, 2020
Merged

Chore: move to GitHub Actions #449

merged 5 commits into from
Aug 11, 2020

Conversation

kaicataldo
Copy link
Member

This PR switches us over from Travis to GitHub Actions. I removed the npm run coveralls step, since that's no longer in our package.json. I also made the Node versions matrix we're using to match the main ESLint repo's, since it's vital that this project works on those platforms. Let me know if that doesn't make sense for whatever reason!

- node Makefile.js test

after_success:
- npm run coveralls
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we giving up on coveralls?

Copy link
Member Author

@kaicataldo kaicataldo Aug 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm definitely not against using coveralls. I removed this because this npm script doesn't currently exist and we don't have node-coveralls in our dev dependencies. But maybe I'm missing something? I looked through the Travis docs to make sure there wasn't some magic happening here, and I couldn't find anything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. Just wanted to make sure we weren't missing anything.

@nzakas nzakas merged commit 4ba3eef into master Aug 11, 2020
@nzakas nzakas deleted the github-actions branch August 11, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants