Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support class static blocks #518

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Conversation

mdjermanovic
Copy link
Member

This PR aims to complete support for class static blocks, by:

  • Updating eslint-visitor-keys dependency to make sure that StaticBlock is included in the VisitorKeys export. We're not using espree.VisitorKeys in eslint packages (we're using eslint-visitor-keys directly), but other dependent packages may be relying on this export.
  • Updating documentation.

Tests that confirm that parsing of class static blocks already works were added in #515.

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit fe07aae into main Nov 18, 2021
@mdjermanovic mdjermanovic deleted the staticblocks-visitorkeys branch November 18, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants