Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for private-in syntax #521

Merged
merged 1 commit into from
Nov 18, 2021
Merged

feat: support for private-in syntax #521

merged 1 commit into from
Nov 18, 2021

Conversation

ota-meshi
Copy link
Member

This PR upgrades acorn to support ES2022 private-in.

@ota-meshi ota-meshi mentioned this pull request Nov 18, 2021
Closed
7 tasks
nzakas
nzakas approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

mdjermanovic
mdjermanovic approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 6839389 into eslint:main Nov 18, 2021
@ota-meshi ota-meshi deleted the paivate-in branch November 18, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
accepted enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ota-meshi @nzakas @mdjermanovic