Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add parser name #562

Merged
merged 2 commits into from
Mar 9, 2023
Merged

feat: Add parser name #562

merged 2 commits into from
Mar 9, 2023

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Mar 7, 2023

This change adds a name export so that Espree can be properly serialized with the new serialization strategy in ESLint.

Refs eslint/eslint#16944

@mdjermanovic
Copy link
Member

There's a lint error.

@nzakas
Copy link
Member Author

nzakas commented Mar 8, 2023

☹️ we really need to get lint-staged setup in this repo.

mdjermanovic
mdjermanovic approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 4368788 into main Mar 9, 2023
@mdjermanovic mdjermanovic deleted the parser-name branch March 9, 2023 08:05
@mdjermanovic mdjermanovic mentioned this pull request Mar 10, 2023
Merged
1 task
coderaiser added a commit to coderaiser/espree that referenced this pull request Mar 11, 2023
@coderaiser
feat: add lint-staged (eslint#562 (comment))
7e44330
@coderaiser coderaiser mentioned this pull request Mar 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nzakas @mdjermanovic