feat: add the eslint-scope package

[snitin315]

Refers #609

[nzakas]

The moved files look good. We also need to update release-please-config.json and .release-please-manifest.json to ensure that release-please knows about this package.

[nzakas]

Did you intend to add more to this config?

[snitin315]

Yeah, this is to match the eslint-scope ESLint config.

I merged both the configs, but, I think we can have different config for packages/espree/tests/lib/** & packages/eslint-scope/tests/lib/** too.

[mdjermanovic]

I think we can have different config for packages/espree/tests/lib/** & packages/eslint-scope/tests/lib/**

Sounds good to me to have different configs, because eslint-scope tests use chai while espree tests don't (I'm not sure why chai was listed in espree dev deps).

[snitin315]

Updated, also removed chai from espree's dev dep.

[nzakas]

Looks like we also need to add eslint-scope to the issue templates.

[snitin315]

Updated 👍🏻

[mdjermanovic]

Looks like npm-license expects dependencies to be installed in node_modules of the start path. But in a workspaces monorepo, dependencies are installed in top-level node_modules.

When I add console.log(Object.keys(deps)); here, it logs only:

[ 'eslint-scope@8.0.2' ]

In the old eslint-scope repo, it logs:

[ 'eslint-scope@8.0.2', 'esrecurse@4.3.0', 'estraverse@5.3.0' ]

So it seems that the license check effectively wouldn't work? I'm not sure how this could be fixed and whether we need a license check for the eslint-scope package. We have a license check in eslint/eslint, and eslint-scope seems to be the only other package with this check.

[nzakas]

In a monorepo, all dependencies end up in the top-level node_modules, so if we do the license check from the root of the repo, I think it should work.

[snitin315]

Providing the top-level path here also didn't work, it was then outputting [ 'eslint-js@1.0.0' ] only.

For now, I have passed additional metadata (See 6405974) to keep the behavior the same as eslint-scope repo, I think we can follow up on this and see how it can be improved for monorepo.

[aladdin-add]

need to update the link after the repo being renamed.

Suggested change

	[](https://github.com/eslint/eslint-scope/actions)
	[](https://github.com/eslint/js/actions)

[snitin315]

Let's update it only after the repo is renamed,

[aladdin-add]

Suggested change

	"homepage": "http://github.com/eslint/eslint-scope",
	"homepage": "https://github.com/eslint/js#readme",

[aladdin-add]

Suggested change

	"repository": "eslint/eslint-scope",
	"repository": "eslint/js",

[aladdin-add]

Suggested change

	"url": "https://github.com/eslint/eslint-scope/issues"
	"url": "https://github.com/eslint/js/issues"

[nzakas]

@snitin315 are you still working on this?

[snitin315]

@nzakas Yes, somehow I missed the last review notification. I've updated the PR, PTAL.

@aladdin-add Let's change the eslint/eslint-scope to eslint/js in a follow-up PR for all packages, once the repository has been renamed.

[aladdin-add]

LGTM, pending @nzakas re-review. thanks!

[nzakas]

All right, moving this forward. I will rename the repo now.