Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First empty line in code fragment breaks line numeration in error messages #77

Closed
vsemozhetbyt opened this issue Jul 5, 2017 · 1 comment
Closed

First empty line in code fragment breaks line numeration in error messages #77

vsemozhetbyt opened this issue Jul 5, 2017 · 1 comment
Labels
accepted bug

Comments

@vsemozhetbyt
Copy link

Test doc:

### Heading

```js

console.log('a')
```

Message:

  4:17  error  Missing semicolon  semi

This should be 5:17.
@vsemozhetbyt vsemozhetbyt mentioned this issue Jul 5, 2017
Closed
@vsemozhetbyt vsemozhetbyt changed the title First empty line breaks line numeration in error messages First empty line in code fragment breaks line numeration in error messages Jul 5, 2017
@btmills
Copy link
Member

btmills commented Feb 27, 2021

remark-parse v7 includes remarkjs/remark#423, which should fix this issue and #78.

btmills added a commit that referenced this issue Feb 27, 2021
@btmills
Update: Upgrade remark-parse to v7 (fixes #77, fixes #78)
dc2d2ec 
`remark-parse@7.0.0` includes
remarkjs/remark#423, which fixes handling of
leading and trailing newlines in fenced code blocks.

Tagging this as `Update` so it'll be semver-minor. Are we comfortable
with a parser major version bump in a semver-minor release?
@btmills btmills mentioned this issue Feb 28, 2021
Closed
@btmills btmills mentioned this issue Apr 5, 2021
Merged
@nzakas nzakas moved this to Complete in Triage Jan 3, 2023
@nzakas nzakas added this to Triage Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted bug
Projects
Triage
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@btmills @vsemozhetbyt @eslintbot