Update: add proper scope analysis (fixes #535)

[mysticatea]

This PR adds proper scope analysis by returning scopeManager object from parseForESLint function.

The scopeManager doesn't contain any types. I think that we can provide parserServices to get types, but I don't contain it in this PR.

This fixes #416, #435, #437, #443, #459, #466, #471, #476, #487, #535, #536, and #545.

• Fixes Interface keys can falsely violate no-use-before-define #435
• Fixes Interface produces no-undef errors #437
• Fixes no-redeclare: false positives for type definitions #443
• Fixes no-shadow if a type alias and function argument share the same name #459
• Fixes What's the recommended way to work around "is not defined" for type definitions? #466
• Fixes Class fields cause false positive no-undef #471
• Fixes TSTypeReference does not emit for React.SFC  #476
• Fixes no-restricted-globals: false positive on class property #487
• Fixes no-dupe-args and no-redeclare false positives in 20.1.0 #535
• Fixes False positive for unused vars used as decorators of properties #536
• Fixes Imported interfaces destructured in function argument gives no-shadow #545

[mysticatea]

I'm a newbie about jest. Please advise me on how to write tests with jest.
Currently, I use snapshot tests with the scope tree after I convert circular references to { $id: X ... } and { $ref: X }.

[platinumazure]

Left some small comments, but otherwise this is looking great!

[mysticatea]

I'm wondering to distinguish declare global {} blocks 🤔 (JamesHenry/typescript-estree#27)

[mysticatea]

I'm wondering on #488.

ImportDeclarations can import type stuff, but we cannot distinguish whether the imported item is a variable or a type. So I cannot ignore types on ImportDeclaration node 🤔

[mysticatea]

I have done except about #488.

[mysticatea]

I hope to separate PR for #488.

Please review!

[JamesHenry]

I'll take a look at this tonight, thanks a lot @mysticatea!

[JamesHenry]

Amazing work, @mysticatea! I just had the one question about the tests left above. I think your approach to the serialization is reasonable, although you can also create a custom matcher for jest as an alternative: https://jestjs.io/docs/en/expect#custom-matchers-api

[JamesHenry]

I don't know if you noticed the pattern I established for running integration tests within docker containers in this project.

With so many potentially closed issues here, it might be nice to add them in as one or more integration tests? Let me know what you think and if you need any help with that

[mysticatea]

🤔 I need time a bit to understand how those integration tests work since I'm not familiar with docker (and I'm on Windows 7).

[JamesHenry]

Ok no problem regarding the integration tests, I can always add them in a follow up

[mysticatea]

Thank you.

I removed assert().

[lvivski]

Why is it still blocked? It would be great to have this PR merged. Right now we have a add a ton of exceptions in config because of all the false-positives

[platinumazure]

Hi @ lvivski, there are a couple of people who still need to review this, including me.

This is open source and we all work as volunteers. We sometimes have other obligations in our lives. I'm sorry that this sometimes results in inconvenience for users who are eagerly waiting for a feature to get merged.

[lvivski]

@platinumazure sorry, I didn't mean to blame anyone but rather wanted to understand if there's anything that I can help with. Obviously everyone has life outside of github and their own obligations. I just wasn't sure what was the actual reason of blocking the merge. Unfortunately I don't have enough experience with eslint internals, but I'll try to understand it.

[platinumazure]

@lvivski Thank you for your understanding. I apologize for misinterpreting your previous comment.

I've just taken a look and I only need to double-check one thing before I can leave my review-- hopefully I'll be able to approve after that check and then we can get this in soon!

[platinumazure]

LGTM, thanks!

[lvivski]

Thank you so much for taking a look into it!

[mysticatea]

@platinumazure Thank you very much!