Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not count UDP messages that were not sent #1380

Conversation

davidBar-On
Copy link
Contributor

When sending a UDP packet fails, do not increase the packet count. That should improve the statistics, as the next packet will be sent with the same number - practically retry of sending the failed packet instead of sending a new packet. Therefore, the client will not count the "retry" as new packet, and more important, the server will not consider the packet that was not sent as a lots packet.

In addition, added debug message in case of NET_SOFTERROR when sending UDP messages, to help debugging.

Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me. Will merge shortly.

As an aside I'm not sure why we increment the sequence number before sending each packet, as opposed to doing it after each successful send.

@bmah888 bmah888 merged commit bd50531 into esnet:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants