Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistics improvements when omitted is used #1498

Merged

Conversation

davidBar-On
Copy link
Contributor

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies:
    master

  • Issues fixed (if any):
    lost_percent greater than 100% #1489

  • Brief description of code changes (suitable for use as a commit message):

Suggested fixes so Sender statistics when --omitt is used:

  1. Fix issue lost_percent greater than 100% #1489: issue was caused because the sender statistics did not ignore the lost packets during the omit period.
  2. Receiver statistics on sender side: use both packet count and omitted counts from receiver. Because of UDP packets delay, the number of ignored packets on sender and receiver are different - more packets are ignored on the sender since some of them did not arrive yet to the receiver at the end of the omit period. Therefore, the %lost packets that used the sender's ignored cont and the receiver's lost count was wrong.

@bmah888 bmah888 self-assigned this Apr 7, 2023
@bmah888 bmah888 added the bug label Apr 7, 2023
@bmah888 bmah888 linked an issue Apr 7, 2023 that may be closed by this pull request
Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice diagnosis of the bug, and thanks for the PR!

There's an issue with interoperability with older versions of iperf3, see feedback comment. I'm not sure how to fix this yet but hopefully you have an idea since you've been thinking about this. Thanks!

src/iperf_api.c Outdated Show resolved Hide resolved
@davidBar-On davidBar-On force-pushed the issue-1489-sender-omitted-statistics branch from f1afa34 to 87cef99 Compare April 8, 2023 12:49
@bmah888
Copy link
Contributor

bmah888 commented May 12, 2023

How to test this:

Server: iperf3 --server
Client: iperf3 --client client.example.org --time 5 --udp --bandwidth=1g (pick some bandwidth that's high enough to cause some packet loss, get a rough baseline of loss rate)
iperf --client client.example.org --time 5 --omit 3 --udp --bandwidth=1g (loss rate will probably be inflated before the fix in this PR, but should be similar with the PR)

Test with various combinations of old and new client and server. Also try --reverse mode.

Note that with a new client sending to an old server with --omit, the client will not be able to display the loss statistics from the server.

@bmah888 bmah888 merged commit 1583601 into esnet:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lost_percent greater than 100%
2 participants