Add debug messges when State changes #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! Just having glanced over it, this seems like a good thing to have, especially since the test state machine isn't super-well-documented and I personally regard it as a bit of magic. |
To better help with this I added a very short textual description of the states to the debug messages (and added some debug messages in additional places where the state is changed). |
bmah888
requested changes
Jul 26, 2024
davidBar-On
force-pushed
the
state_change_debug_messages
branch
from
218e072 to
3f7dbae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:Master
Issues fixed (if any): None
Brief description of code changes (suitable for use as a commit message):
Added DEBUG_LEVEL_INFO debug messages when state changes. I found these debug messages useful in different error cases, especially when there is a problem with the client/server interface.