Reduce CPU usage when test baud rate is limited #1743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
master
or3.1-STABLE
) to which this pull request applies:master
Issues fixed (if any): 100% CPU utilization in a limited rate test #1741
Brief description of code changes (suitable for use as a commit message):
Suggested fix to #1741 for (significantly) reduce iperf3 send CPU usage when
--baud
limits the sending baud rate. The suggested change usesnanosleep()
orclock_nanosleep()
to sleep between sends instead of using the pacing timer. This change seem to work fine because of the current usage of threads and since theselect()
is used only in the main thread.clock_nanosleep()
has a cleaner implementation, so its use is preferred. However, since it seem to be newer thannanosleep()
,nanosleep()
is used ifclock_nanosleep()
is not supported. Both give similar results. If both functions are not supported, then the legacy behavior is used.The
--pacing-timer
option is removed. However the related variables/functions are not removed in case they are used as part of the library.(By the way, it seems that
iperf_send_mt()
can be simplified. E.g. theif (sp->sender)
is probably redundant. In addition, the use of burst/multisend is also probably redundant, since the sending threads do not useselect()
.)