Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serde defaults to the client configuration struct #78

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

DaneSlattery
Copy link
Contributor

When deserializing this before the addition of PMF and scan method, one could pass a json struct containing just r#"{"ssid":"abc", "auth_method":"WPA2Personal", "password":"123"}"#

And this would automatically deserialize despite omitting the bssid and channel, neither of which are usually known when connecting to WiFi.

The new code uses the defaults for scan method and PMF config, which are more of an advanced use-case concern.

When deserializing this before the addition of PMF and scan method, one could pass a json struct containing just 
`r#"{"ssid":"abc", "auth_method":"WPA2Personal", "password":"123"}"#`

And this would automatically deserialize despite omitting the `bssid` and `channel`, neither of which are usually known when connecting to WiFi.

The new code uses the defaults for scan method and PMF config, which are more of an advanced use-case concern.
@ivmarkov
Copy link
Collaborator

Thanks!

@ivmarkov ivmarkov merged commit bba821c into esp-rs:master Sep 17, 2024
1 check passed
@DaneSlattery
Copy link
Contributor Author

Oh, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants