Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equality traits for OTA slots #79

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Conversation

DaneSlattery
Copy link
Contributor

I would like to be able to compare slots and use this in other abstractions that require partialeq.

Copy link
Collaborator

@ivmarkov ivmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but then also put Eq and Hash.

@ivmarkov
Copy link
Collaborator

Hash is actually available even when STD is not around (but HashMap itself isn't).

@DaneSlattery
Copy link
Contributor Author

I see, but the other structs in this module have if gated behind the std feature , such as SlotState for example

@ivmarkov
Copy link
Collaborator

I see, but the other structs in this module have if gated behind the std feature , such as SlotState for example

That's because X years ago I myself did not realize Hash exists in no_std. These other structs need to be fixed.

@ivmarkov ivmarkov merged commit 8986eac into esp-rs:master Oct 14, 2024
1 check passed
@DaneSlattery
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants