Timers runtime isr binding #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
force-pushed
the
timers-runtime-isr-binding
branch
from
f013eb1
to
39fa214
Compare
bjoernQ
commented
Mar 26, 2024
20 tasks
JurajSadel
approved these changes
Mar 27, 2024
bjoernQ
force-pushed
the
timers-runtime-isr-binding
branch
2 times, most recently
from
1ac1cec
to
4ed878b
Compare
MabezDev
reviewed
Apr 1, 2024
bjoernQ
force-pushed
the
timers-runtime-isr-binding
branch
2 times, most recently
from
8609b7e
to
de14dd7
Compare
jessebraham
approved these changes
Apr 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Looks like the HIL tests need updating |
bjoernQ
force-pushed
the
timers-runtime-isr-binding
branch
from
de14dd7
to
febf92a
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
This implements runtime ISR binding for SYSTIMER and TIMG. It makes Systimer's DelayNs implementation available when the
asyncfeature is active.Two new examples are added
embassy_systimer_delay.rs- uses the DelayNs implementationembassy_hello_world_systimer.rs- same asembassy_hello_worldbut using the systimer time-driver (not for ESP32 or ESP32-S2), I added it since we currently don't check that driver (and also to test my changes)Testing
Running the existing (adapted) examples and added examples