Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fixes for array access panics in esp-ieee802154 #1923

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

nand-nor
Copy link
Contributor

@nand-nor nand-nor commented Aug 11, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Adds additional array access checks to avoid panics in various frame processing methods.

Description

Adds some additional checks as a follow on to #1862, to resolve various array-access related panics I have seen (although worth noting these are very rare). Similar to #1862 I view these as just band-aids, I still need to dig in to determine root cause. But adding these checks will help with fault tolerance / recoverability either way. Also fixes an off-by-one error introduced in fix from #1862

Testing

Have confirmed it builds and runs as expected using the esp-openthread crate's example binary, on both esp32-h2 and esp32-c6 targets. Currently running some longevity tests as these only seem to pop up after many days/weeks of continuous operation, so will follow up with any needed additions once longevity tests complete.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JurajSadel JurajSadel added this pull request to the merge queue Aug 12, 2024
Merged via the queue into esp-rs:main with commit 1371b11 Aug 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants