Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove most trait implementation features from esp-hal #2047

Closed
wants to merge 1 commit into from
Closed

Remove most trait implementation features from esp-hal #2047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions esp-hal/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ strum = { version = "0.26.3", default-features = false, featu
void = { version = "1.0.2", default-features = false }
usb-device = { version = "0.3.2", optional = true }
rand_core = "0.6.4"
ufmt-write = { version = "0.1.0", optional = true }
ufmt-write = "0.1.0"
xtensa-lx = { version = "0.9.0", optional = true }

# IMPORTANT:
Expand Down Expand Up @@ -160,8 +160,6 @@ embedded-hal = ["dep:embedded-hal", "dep:embedded-hal-nb", "dep:embedded-can"]
embedded-hal-02 = ["dep:embedded-hal-02"]
## Implement the traits defined in `embedded-io` for certain peripherals.
embedded-io = ["dep:embedded-io"]
## Implement the `ufmt_write::uWrite` trait for certain peripherals.
ufmt = ["dep:ufmt-write"]

#! ### PSRAM Feature Flags
## Use externally connected PSRAM (2MB).
Expand All @@ -184,7 +182,7 @@ opsram-8m = []
opsram-16m = []

# This feature is intended for testing; you probably don't want to enable it:
ci = ["async", "embedded-hal-02", "embedded-io", "ufmt", "defmt", "bluetooth", "place-spi-driver-in-ram"]
ci = ["async", "embedded-hal-02", "embedded-io", "defmt", "bluetooth", "place-spi-driver-in-ram"]

[lints.clippy]
mixed_attributes_style = "allow"
Expand Down
2 changes: 0 additions & 2 deletions esp-hal/src/uart.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1662,7 +1662,6 @@ impl_instance!(UART1, 1, U1TXD, U1RXD, U1CTS, U1RTS, Uart1);
#[cfg(uart2)]
impl_instance!(UART2, 2, U2TXD, U2RXD, U2CTS, U2RTS, Uart2);

#[cfg(feature = "ufmt")]
impl<T, M> ufmt_write::uWrite for Uart<'_, T, M>
where
T: Instance,
Expand All @@ -1681,7 +1680,6 @@ where
}
}

#[cfg(feature = "ufmt")]
impl<T, M> ufmt_write::uWrite for UartTx<'_, T, M>
where
T: Instance,
Expand Down
2 changes: 0 additions & 2 deletions esp-hal/src/usb_serial_jtag.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,6 @@ where
}
}

#[cfg(feature = "ufmt")]
impl<M> ufmt_write::uWrite for UsbSerialJtag<'_, M>
where
M: Mode,
Expand All @@ -443,7 +442,6 @@ where
}
}

#[cfg(feature = "ufmt")]
impl<M> ufmt_write::uWrite for UsbSerialJtagTx<'_, M>
where
M: Mode,
Expand Down
Loading