Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix I8080.set_byte_order() #2487

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dominaezzz
Copy link
Collaborator

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Fixes #2362 by splitting the set_byte_order into two functions.
The user is now responsible for calling the right one depending on the bus width, which will be straight forward for most users.
Those that share the bus between 8-bit and 16-bit devices will have to do a little more work.

Testing

Works as expected on my Slint app.

@yanshay pls confirm this PR works for you too.

@bugadani
Copy link
Contributor

bugadani commented Nov 7, 2024

We either should use a separate BitOrder enum, or call the thing Endianness (And it's variants MsbFirst and LsbFirst because what even is the default bit/byte order?).

I guess we'll do this separately, along with providing a Config struct if we ever figure those parts out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i8080.set_byte_order seems to be incorrect starting 0.21.0
2 participants