Support ESP32-C2 with 26MHz Xtal #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
reviewed
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to ESP-IDF most development boards use a 40MHz xtal but 26MHz are available so it makes sense to support it.
However, since 40MHz is also the default for ESP-IDF it's also the default for esp-hal.
I tested this on both, 40MHz and 26MHz versions and checked SPI, I2C and UART with a logic analyzer - looks good.
Please note: If you are using a 26MHz chip you need to supply a custom bootloader configured for 26MHz otherwise clock config will panic.
Also this changes the run alias to include the
flashcommand - sinceespflash 2.0RCs are available for some time now we should do that - also apparently I'm the only one usingcargo run