Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RADIO peripheral #397

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Add RADIO peripheral #397

merged 3 commits into from
Feb 21, 2023

Conversation

MabezDev
Copy link
Member

  • Rework macros to allow non-pac peripheral structs
  • Add RadioExt trait to split the RADIO into each feature
  • Refactor hacky sealed impl to not need Deref anymore
  • Add radio module behind radio cfg (For upcoming chips without one, P4)

Related issue: esp-rs/esp-wifi-sys#137

@MabezDev MabezDev requested review from bjoernQ and jessebraham and removed request for bjoernQ February 20, 2023 21:54
bjoernQ
bjoernQ approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jessebraham
jessebraham approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm admittedly not a huge fan of the additional boolean in the peripherals! macro, however this is only used internally and isn't worth blocking on IMO, so LGTM otherwise.

@jessebraham jessebraham merged commit 80996e3 into esp-rs:main Feb 21, 2023
MabezDev added a commit to MabezDev/esp-hal that referenced this pull request Mar 31, 2023
@MabezDev
Add RADIO peripheral (esp-rs#397)
b1cc0f2 
* Allow the creation of peripherals _not_ from the pac in the peripherals macro

* Add RADIO peripheral

- Remove DerefMut hack, replace with proper Sealed impls
- Add RADIO peripheral for all chips

* Add RADIO peripheral with split method into each radio feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MabezDev @jessebraham @bjoernQ