Disable all watchdog timers at startup by default #763
Conversation
|
It's definitely a good change, less boilerplate is always appreciated! Weirdly enough, though, I never had to disable TIMG0/1 WDTs. Do you happen to know why? Edit: maybe it's a bootloader thing...? |
|
I'm not 100% sure to be honest, I've noticed the same thing though. Just included for completeness here. I think you may be right and there may be some configuration for that somewhere, but again not sure. |
If these WDTs are enabled or not depends on whether it's an direct-boot or a esp-idf-bootloader boot (and I think for the esp-idf bootloader it might be even configurable - not sure). So to be on the safe side we just disable all the WDTs - won't hurt if they are already disabled |
|
Looks good but it seems it breaks the |
jessebraham
force-pushed
the
feature/disable-watchdogs
branch
from
670aa52 to
324b326
Compare
Ahh yeah my bad, misunderstood the example so I thought it was working 😀 I had accidentally introduced a bug, should be fixed now. (I did test both examples for all devices this time, and they seem to be working as far as I can tell. I opened #766 but this was already an issue in |
| - Add multicore-aware embassy executor for Xtensa MCUs (#723). | ||
| - Add interrupt-executor for Xtensa MCUs (#723). |
There was a problem hiding this comment.
Why are those CHANGELOG entries removed?
There was a problem hiding this comment.
they were duplicates caused by incorrect rebasing
There was a problem hiding this comment.
Duplicate entry, to avoid needing to rebase PRs all the time we modify the merge settings for that file in .gitattributes, it's not perfect so sometimes things need cleaning up.
I just happened to do that while I was modifying this file anyway.
There was a problem hiding this comment.
Gotcha. I didn't see they were present 2 lines below 😅
* Rework watchdog timer drivers to allow enabling/disabling and feeding without traits * Disable all watchdogs prior to `main` using the `__post_init` hook * Update all watchdog-related examples * Update CHANGELOG * Address review comment
__post_inithook to disable all watchdog timers at startupembedded-haltraits, addenablefunctionsAll modified examples have been tested, and I tried a couple others as well to ensure the watchdogs were indeed disabled.