HTTP header keys are case-insensitive #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `uncased` crate when HTTP client is enabled to ensure this
|
This is great! I'll merge it even though CI fails, as it fails due to a completely different reason. With that said, the experimental HTTPD server needs a similar fix here. Are you up for applying the same fix there as well? |
jendakol
pushed a commit
to jendakol/esp-idf-svc
that referenced
this pull request
Sep 23, 2022
Use the `uncased` crate when HTTP client is enabled to ensure this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
uncasedcrate when HTTP client is enabled to ensure this.Fixes #39 in my brief test of my project, tested on an ESP32-C3.