Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to esp-hal 0.19 #35

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

GnomedDev
Copy link
Contributor

Compiles on my project, but needs testing by someone who has a project that actually works right now.

@GnomedDev GnomedDev force-pushed the update/esp-hal-0.19 branch from 74ab361 to 13c40bc Compare July 16, 2024 16:16
@AnthonyGrondin
Copy link
Contributor

You can test that all examples build, using just, and you can also run the examples in examples/ to test at runtime.

Ex: SSID=<SSID> PASSWORD=<PASS> cargo +esp esp32s3 --release --example sync_server --features="esp-wifi/wifi-logs"

Currently esp-wifi doesn't compile with the feature embedded-svc enabled:

error[E0063]: missing fields `pmf_cfg` and `scan_method` in initializer of `embedded_svc::wifi::ClientConfiguration`
    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/esp-wifi-0.7.0/src/wifi/mod.rs:2751:21
     |
2751 |                     embedded_svc::wifi::ClientConfiguration {
     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `pmf_cfg` and `scan_method`

error[E0063]: missing fields `pmf_cfg` and `scan_method` in initializer of `embedded_svc::wifi::ClientConfiguration`
    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/esp-wifi-0.7.0/src/wifi/mod.rs:2778:21
     |
2778 |                     embedded_svc::wifi::ClientConfiguration {
     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `pmf_cfg` and `scan_method`

For more information about this error, try `rustc --explain E0063`.
error: could not compile `esp-wifi` (lib) due to 2 previous errors

This is due to the breaking change in: esp-rs/embedded-svc#75

@GnomedDev
Copy link
Contributor Author

Got it, I've opened an issue on the esp-hal repo for that build failure. This is blocked on that for now.

@bjoernQ
Copy link
Collaborator

bjoernQ commented Jul 17, 2024

The good thing is that embedded-svc is totally optional - we have an inherent version of the wifi API - you would just need to adjust the imports

@GnomedDev GnomedDev force-pushed the update/esp-hal-0.19 branch 2 times, most recently from 9c39af6 to 67a5f2c Compare July 17, 2024 12:48
@GnomedDev GnomedDev force-pushed the update/esp-hal-0.19 branch from 67a5f2c to b95ce01 Compare July 17, 2024 13:02
@GnomedDev
Copy link
Contributor Author

CI is passing, now that esp-rs/esp-hal#1817 is fixed.

Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ merged commit b10f303 into esp-rs:main Jul 18, 2024
1 check passed
@GnomedDev GnomedDev deleted the update/esp-hal-0.19 branch July 18, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants