Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in debug_assist register name #270

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Fix typo in debug_assist register name #270

merged 6 commits into from
Aug 19, 2024

Conversation

JurajSadel
Copy link
Contributor

As discovered in esp-rs/esp-hal#1961, debug_assist has a typo in a register on C3, C6, and H2. This fixes it.

cc @bugadani

@bugadani bugadani linked an issue Aug 19, 2024 that may be closed by this pull request
Typo in debug assist on all chips except esp32c3 #269
Closed
@JurajSadel JurajSadel mentioned this pull request Aug 19, 2024
Merged
5 tasks
bugadani
bugadani approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@bugadani bugadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think that's all :) Not sure what's the process here, if I can merge this PR or not, so here's my approval for now :)

@JurajSadel JurajSadel merged commit bf5890e into esp-rs:main Aug 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugadani bugadani bugadani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in debug assist on all chips except esp32c3
2 participants
@JurajSadel @bugadani