Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolchain update, fix cargo-generate, and fix scripts #17

Merged
merged 12 commits into from
Aug 10, 2022
Merged

Toolchain update, fix cargo-generate, and fix scripts #17

merged 12 commits into from
Aug 10, 2022

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Jul 26, 2022

  • Updated toolchain version to 1.62.1.0
  • Added an extra step that installs cargo-generate via cargo if the binary installation failed
  • Formated scripts
  • Fixed an issue where elf path in scripts was not correct for projects with - on the name
  • Update ESP32-C3: Add driver for RTC Watchdog Timer (RWDT) esp-hal#134 changes
  • Update xtensa-atomic-emulation-trap version

@SergioGasquez
Copy link
Member Author

Checks are failing since cargo-generate released a new version yesterday and CI for generating binary assets failed, see: cargo-generate/cargo-generate#708

@jessebraham
Copy link
Member

Are we going to have to do this every time there's a new release? Are we able to automatically use the latest version in any way?

@SergioGasquez
Copy link
Member Author

Are we going to have to do this every time there's a new release? Are we able to automatically use the latest version in any way?

At the moment, yes. See: esp-rs/rust-build#125 (comment)

@jessebraham
Copy link
Member

Is there a reason we can't use https://github.com/esp-rs/rust-build/releases/latest instead of specifying the version? I don't know if this will ignore pre-releases or not, I guess that would be my only concern.

@SergioGasquez
Copy link
Member Author

Is there a reason we can't use https://github.com/esp-rs/rust-build/releases/latest instead of specifying the version? I don't know if this will ignore pre-releases or not, I guess that would be my only concern.

We could use latest, but that would be more "unstable", I've added the issue to today's community meeting to discuss it

@SergioGasquez
Copy link
Member Author

I've added an extra step that installs cargo-generate via cargo if the binary installation failed since we don't know when cargo-generate binaries will be uploaded and we already had other issues with cargo-generate installation so having 2 sources can be useful in reducing third parties errors

@SergioGasquez SergioGasquez changed the title Update toolchain version to 1.62.1.0 Toolchain update, fix cargo-generate, and fix scripts Aug 5, 2022
@jessebraham jessebraham merged commit 2ed2279 into esp-rs:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants