Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify task switching #279

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Simplify task switching #279

merged 1 commit into from
Oct 12, 2023

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Oct 11, 2023

TrapFrame implements Copy for both xtensa and riscv archs.

I've also simplified the PC handling for RISC-V which looked redundant but I'm not 100% confident in those changes.

@bugadani bugadani marked this pull request as ready for review October 11, 2023 13:41
@bjoernQ
Copy link
Contributor

bjoernQ commented Oct 11, 2023

Good idea. Unfortunately crashes on RISC-V targets

@bugadani bugadani force-pushed the frame branch 2 times, most recently from 919e45a to 5919da7 Compare October 11, 2023 16:19
@bugadani
Copy link
Contributor Author

Too bad. I've reverted the RISC-V changes as I don't have the tools to debug them.

@bjoernQ
Copy link
Contributor

bjoernQ commented Oct 11, 2023

I can have a look at the RISC-V side of this in a separate PR then

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ merged commit 9f64256 into esp-rs:main Oct 12, 2023
7 checks passed
@bugadani bugadani deleted the frame branch October 12, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants