Skip to content

Commit

Permalink
chore: Code cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
SergioGasquez committed Feb 22, 2024
1 parent 0ea9832 commit 76d322d
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 10 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/hil.yml
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ jobs:
fi
result=$(espflash_app/espflash read-flash 0 0x200 flash_content.bin 2>&1)
echo "$result"
if [[ ! $result =~ "Flash content suscesfully read and written to" ]]; then
if [[ ! $result =~ "Flash content successfully read and written to" ]]; then
exit 1
fi
echo "Checking if flash is empty"
Expand All @@ -180,13 +180,13 @@ jobs:
run: |
result=$(espflash_app/espflash save-image --merge --chip ${{ matrix.board }} ${{ env.ESPFLASH_APP }} app.bin 2>&1)
echo "$result"
if [[ ! $result =~ "Image suscesfully saved!" ]]; then
if [[ ! $result =~ "Image successfully saved!" ]]; then
exit 1
fi
echo "Writting binary"
result=$(espflash_app/espflash write-bin 0x0 app.bin 2>&1)
echo "$result"
if [[ ! $result =~ "Binary suscesfully written to flash!" ]]; then
if [[ ! $result =~ "Binary successfully written to flash!" ]]; then
exit 1
fi
echo "Monitoring..."
Expand Down
4 changes: 0 additions & 4 deletions espflash/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,3 @@ cli = [
"dep:update-informer",
]
serialport = ["dep:serialport"]

# [dev-dependencies]
# assert_cmd = "2.0.12"
# predicates = "3.0.4"
2 changes: 2 additions & 0 deletions espflash/src/bin/espflash.rs
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,8 @@ pub fn erase_parts(args: ErasePartsArgs, config: &Config) -> Result<()> {
.connection()
.reset_after(!args.connect_args.no_stub)?;

info!("Specified partitions successfully erased!");

Ok(())
}

Expand Down
2 changes: 1 addition & 1 deletion espflash/src/cli/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ pub fn save_elf_as_image(
}
}

info!("Image suscesfully saved!");
info!("Image successfully saved!");

Ok(())
}
Expand Down
4 changes: 2 additions & 2 deletions espflash/src/flasher/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -976,7 +976,7 @@ impl Flasher {
};
self.write_bins_to_flash(&[segment], progress)?;

info!("Binary suscesfully written to flash!");
info!("Binary successfully written to flash!");

Ok(())
}
Expand Down Expand Up @@ -1153,7 +1153,7 @@ impl Flasher {
file.write_all(&data)?;

info!(
"Flash content suscesfully read and written to '{}'!",
"Flash content successfully read and written to '{}'!",
file_path.display()
);

Expand Down

0 comments on commit 76d322d

Please sign in to comment.