Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to cargo-espflash to flash file without having to build the project #198

Closed
SergioGasquez opened this issue Jun 23, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@SergioGasquez
Copy link
Member

Maybe, if we have an argument pointing to an elf file, flash it instead of building the project and then flashing the resulting file.

@SergioGasquez SergioGasquez added the enhancement New feature or request label Jun 23, 2022
@jessebraham jessebraham moved this to Todo in esp-rs Jun 23, 2022
@MabezDev
Copy link
Member

This is what espflash does already! Easy to confuse with cargo-espflash which is the cargo wrapper that also builds the project. They are actually two different executables.

@SergioGasquez
Copy link
Member Author

Sorry, I meant cargo-espflash. My point was to get this feature inside cargo-espflash so users that want to flash a file without building the project do not need to install espflash or rely on idf tool.

@jessebraham jessebraham changed the title Add an option to flash file without having to build the project Add an option to cargo-espflash to flash file without having to build the project Jul 4, 2022
@tcbennun
Copy link

Agreed on this. It actually can cause a rebuild in some cases (e.g. performing a workspace build then using cargo espflash to flash one of the binary crates).

@MabezDev
Copy link
Member

I believe this was closed via #205

Repository owner moved this from Todo to Done in esp-rs Jul 28, 2022
@jessebraham
Copy link
Member

This was closed erroneously, re-opening.

@jessebraham jessebraham reopened this Aug 9, 2022
Repository owner moved this from Done to In Progress in esp-rs Aug 9, 2022
@jessebraham
Copy link
Member

After thinking on this for awhile, I actually think it's not necessary. If the project is already built then normal execution is fine, the time added by rustc for an already built project is negligible.

Repository owner moved this from In Progress to Done in esp-rs Sep 15, 2022
@jessebraham jessebraham removed this from esp-rs Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants