Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serial-monitor subcommand #205

Merged
merged 4 commits into from
Jul 6, 2022
Merged

Add serial-monitor subcommand #205

merged 4 commits into from
Jul 6, 2022

Conversation

SergioGasquez
Copy link
Member

Include serial-monitor subcommand in cargo-espflash and espflash to allow monitoring a serial monitor without flashing.
Closes #197

MabezDev
MabezDev approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you run rustfmt to fix the CI?

@SergioGasquez
Copy link
Member Author

SergioGasquez commented Jul 6, 2022 •
edited
Loading

LGTM! Could you run rustfmt to fix the CI?

It should now be fixed!

@MabezDev MabezDev merged commit d0bd11b into esp-rs:master Jul 6, 2022
@MabezDev MabezDev mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

@jessebraham jessebraham Awaiting requested review from jessebraham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add argument to monitor without building/flashing
2 participants
@SergioGasquez @MabezDev