Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --no-default-features #645

Closed
etiennetremel opened this issue Jun 1, 2024 · 2 comments · Fixed by #647
Closed

Add support for --no-default-features #645

etiennetremel opened this issue Jun 1, 2024 · 2 comments · Fixed by #647

Comments

@etiennetremel
Copy link
Contributor

It would be a nice addition to allow disabling default features via a flag, similar to what cargo build --no-default-features --features one,two does.

Currently, espflash support adding features but doesn't allow disabling the one default one.

Related to #305

@SergioGasquez
Copy link
Member

Could you elaborate on your use case? Currently, the only default feature of espflash is cli which can be disabled when used as a library and its fundamental when using it as a binary.

@etiennetremel
Copy link
Contributor Author

Sorry, I wasn't really clear.

I'm using espflash from the CLI, so the feature that are being compiled and flashed into the esp32 are from my project, not from the espflash Cargo.toml:

cargo espflash flash --release --features one,two

My project has default features which I do not want, using the cargo build there is a flag that can be used to drop all default features but that's not a flag available on the espflash flash sub command.

I'm expecting to be able to do the same as cargo build, which would look like this:

cargo espflash flash --release --features one,two --no-default-features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants