feat: add --no-default-features flag #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
I tested it manually by compiling the cargo-esflash binary and flashing my home sensor project onto a esp32 dev board: https://github.com/etiennetremel/esp32-home-sensor. Not sure if this is the right thing to do, but the project make use of Cargo features to enable/disable sensors during compile time. For example, if I want to connect 2 sensors to the dev board (in this case sds011 and bme280), I can use the following command: ../../esp-rs/espflash/target/release/cargo-espflash espflash flash --release --no-default-features --features sds011,bme280 |
SergioGasquez
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default features are still included while using the following command:
This PR add the
--no-default-featuresflag to mirror cargo features functionalities.Close #645