bugfix: Don't use canonicalized strings on Windows

[JurajSadel]

closes #209

[MabezDev]

Just passing by, I don't understand the full issue, but could it be the to_string_lossy that's the real issue? find_serial_port should probably take a PathBuf, not a String?

[MabezDev]

Just passing by, I don't understand the full issue, but could it be the to_string_lossy that's the real issue? find_serial_port should probably take a PathBuf, not a String?

We looked into this, it seems canonicalize doesn't work with "dummy" device paths like COM4 for example, hence this error. Therefore this change is correct.

[jessebraham]

Would you mind adding a comment explaining this please? There are a couple things going on here and it isn't immediately clear to others what the motivation for this is:

• The call to canonicalize() was originally added to resolve espflash does not follow symlinks on Linux #177
• This then causes issues on Windows, so we need to handle Windows/Posix differently