Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: rename image format modules to allow for future expansion #249

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

jessebraham
Copy link
Member

This is the third in my series of planned refactors, following #245 and #247. This should be it for now, I hope.

Nothing too crazy here:

  • Renamed the image formats to be a bit more specific, paves the way for adding additional image formats in the future
    • This is done in anticipation of eventually adding mcuboot support
  • Moves a couple functions into the modules they belong in

@jessebraham jessebraham changed the title Refactor: rename image formats module to allow for future expansion Refactor: rename image format modules to allow for future expansion Oct 3, 2022
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MabezDev
Copy link
Member

MabezDev commented Oct 5, 2022

LGTM! I always found the old layout confusing when trying to find the extended header stuff :D.

@MabezDev MabezDev merged commit d9aa971 into esp-rs:master Oct 5, 2022
@jessebraham jessebraham deleted the fixes/refactor-3 branch October 5, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants