Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: esp32c3 direct boot #358

Merged
merged 3 commits into from
Mar 8, 2023
Merged

fix: esp32c3 direct boot #358

merged 3 commits into from
Mar 8, 2023

Commits on Mar 1, 2023

  1. fix: esp32c3 direct-boot format 

    Prior to this change, attempting to `espflash flash` with the `--format
direct-boot` argument targeting an esp32c3 would fail, reporting:

```
Error: espflash::unsupported_image_format

  × Image format direct-boot is not supported by the esp32c3 revision v0.3
  help: The esp32c3 only supports direct-boot starting with revision 3
```

However, direct-boot on this board was working prior to the changes in
b25af06, and looking at the [docs][esp32c3 revisions] it seems that the
mapping that was chosen for the `c3` specifically was `v0.REVISION`:

> ECO  | Revision (Major.Minor)
> -----------------------------
> ECO1 | v0.1
> ECO2 | v0.2
> ECO3 | v0.3
> ECO4 | v0.4

[esp32c3 revisions]: https://docs.espressif.com/projects/esp-idf/en/latest/esp32c3/api-reference/system/chip_revision.html#revisions
    @sethp
    sethp committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    491d86a View commit details
    Browse the repository at this point in the history

  2. refactor+docs: move & reword esp32c3 specific err 

    This change rewords the error message from "revision 3" to "revision 3
(v0.3)" in an effort to clarify the mapping between hardware revisions
and major/minor version numbers.

Additionally, it moves the esp32c3-specific error closer to the actual
version check to make it easier to keep both in sync.
    @sethp
    sethp committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    c183dfa View commit details
    Browse the repository at this point in the history

  3. chore: remove unused import 

    Previously, `cargo check --all-targets` reported this import as unused.
Since it's just `const u16`, the import is probably side-effect free and
indeed safe to remove.
    @sethp
    sethp committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    f0ab4dd View commit details
    Browse the repository at this point in the history