Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config file parsing #382

Merged
merged 12 commits into from
Apr 4, 2023
Merged

Fix config file parsing #382

merged 12 commits into from
Apr 4, 2023

Conversation

SergioGasquez
Copy link
Member

  • Remove serde-hex since it's no longer compatible with the new toml version
  • Include the hex crate
  • Add functions for serializing and deserializing
  • Add test for serialization and deserialization methods

Not sure if this is the best way, but the file needed to be backward compatible.

@SergioGasquez SergioGasquez linked an issue Apr 4, 2023 that may be closed by this pull request
Config file parsing issue #383
Closed
MabezDev
MabezDev requested changes Apr 4, 2023
View reviewed changes
espflash/src/cli/config.rs Outdated Show resolved Hide resolved
bjoernQ
bjoernQ reviewed Apr 4, 2023
View reviewed changes
espflash/src/cli/config.rs Outdated Show resolved Hide resolved
bjoernQ
bjoernQ reviewed Apr 4, 2023
View reviewed changes
espflash/src/cli/config.rs Outdated Show resolved Hide resolved
@bjoernQ
Copy link
Contributor

bjoernQ commented Apr 4, 2023

maybe you also want to adapt test_parse_u16_hex

@SergioGasquez
Copy link
Member Author

maybe you also want to adapt test_parse_u16_hex

Ups, forgot to push the changes after updating it. Thanks!

bjoernQ
bjoernQ approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MabezDev
MabezDev approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev MabezDev merged commit e8cd385 into esp-rs:main Apr 4, 2023
@SergioGasquez SergioGasquez deleted the fix/config-parsing branch April 4, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config file parsing issue
3 participants
@SergioGasquez @bjoernQ @MabezDev